-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review fix #134
Review fix #134
Conversation
This reverts commit b6f00b9.
…s are present, including in uploaded dataset
@triphook This is not related to your edits (was already there), but do you know if the renv folder at the top level of the repo is needed? I also noticed a lot of notes printed when I queried the WQP on the import tab. Can you take a look to check these are correct? Thanks! [1] "tadat$raw has been changed (i think?)" |
In the filtering page, MeasureQualifierCode is the filter option - should the TADA.MeasureQualifierCode.Def option be visible in this update? Downloading both test datasets and WQP queried data sets as zip files is working throughout the app. |
This should have happened automatically when we added this to the key fields in TADA_FieldCounts in the package, which is leveraged in mod_filtering.R. We'll have to look into why it is still not working |
move config from imports to suggests
Fixed all bugs related to downloads. Added new button for downloading final (with flagged records removed) vs intermediate (flagged rows retained) datasets.